Log error on accessing non-initialized lifetime #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Add `LogErrorIfLifetimeIsNotInitialized` to be able to disable this behaviour
|
Have you tried running Rider or ReSharper with this patch applied? I have a feeling that a lot of things will be broken, but I agree this change overall |
No, but if it's too hard to fix everything during the merge, I'll disable that assertion on the Rider/R# side and then re-enable it after all the problems are fixed. |
Fix tests Check IsInitialized in ValueLifetimed + add an assertion that the passed lifetime is initialized
Iliya-usov
force-pushed
the
usov/lifetime-diagnostics
branch
from
1145b3b to
87fa5f6
Compare
ForNeVeR
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.