Skip to content

Commit

Permalink
Upd the comment in the tests
Browse files Browse the repository at this point in the history
  • Loading branch information
eymar committed Aug 5, 2024
1 parent 9cbf641 commit 8c0652a
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions skiko/src/commonTest/kotlin/org/jetbrains/skia/FontTests.kt
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,10 @@ class FontTests {
}

@Test
// Maybe it's a reason why this test fails with m122:
// https://github.com/google/skia/blob/main/RELEASE_NOTES.md#milestone-122
// SkFont::getTypeface() will no longer return a nullptr to indicate "the default typeface".
// If left unspecified, SkFonts will use an empty typeface (e.g. no glyphs).
fun emptyFontMetricsAreZero() {
// The behaviour was changed in m122.
// https://github.com/google/skia/blob/main/RELEASE_NOTES.md#milestone-122
// There is no default font anymore.
Font(Typeface.makeEmpty()).use { font ->
val metrics = font.metrics
assertTrue(
Expand Down

0 comments on commit 8c0652a

Please sign in to comment.