Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PixelRef.rowBytes type #928

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix PixelRef.rowBytes type #928

wants to merge 1 commit into from

Conversation

9il
Copy link

@9il 9il commented May 18, 2024

BTW, pixels pointer is missing in PixelRef.

@9il
Fix PixelRef.rowBytes type
55034ff 
BTW, `PixelRef` is missing `pixels` pointer.
@elijah-semyonov
Copy link
Contributor

elijah-semyonov commented May 21, 2024 •
edited
Loading

It's indeed not a pointer:
https://api.skia.org/classSkPixelRef.html#ae3f171a1d99f2adfd0683654dac3efc7

@igordmn this fix is correct one, seems like we simply didn't use this API anywhere?
Can it possibly break some binary interfacing?

MatkovIvan
MatkovIvan requested changes Jun 12, 2024
View reviewed changes
Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type in JNI/C++ needs to be updated too.

skiko/skiko/src/jvmMain/cpp/common/PixelRef.cc

Line 17 in 5ed970f

extern "C" JNIEXPORT jlong JNICALL Java_org_jetbrains_skia_PixelRefKt_PixelRef_1nGetRowBytes

@MatkovIvan MatkovIvan requested a review from igordmn June 12, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatkovIvan MatkovIvan MatkovIvan requested changes

@igordmn igordmn Awaiting requested review from igordmn

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@9il @elijah-semyonov @MatkovIvan