-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare resources in the GitHub action for test scripts #220
Conversation
I accidentally submitted this against It's possible that all I'm missing right now is a proper |
You can switch the into branch if you edit the PR |
Hah! Right under my nose. I kept seeing only the title field appear, and wouldn't spot the pop-up. 🙄 Many thanks. |
Doesn't work
Thanks! As you can see I made a mess of it again :) sorry! But the setup does work now and without using dnsmasq. Maybe some iptables rules can be removed / simplified and they definitely should be moved again from the test script into the yaml. |
4f67905
to
92687a0
Compare
Thanks a lot @jonct! Even though I did some cleanup and merged this into develop, feel free to suggest improvements :) |
Niiiiiiiice! 💯 Full endorsement. No notes. |
Hmm the test suddenly starts failing... Podman: https://github.com/Jip-Hop/jailmaker/actions/runs/9850014285/job/27194605669
Docker: https://github.com/Jip-Hop/jailmaker/actions/runs/9849986977/job/27194527864
|
I expect that this will set up the appropriate networking for automated tests, as requested.
These steps are working here, in a fresh Ubuntu Server Live CD on VMware Fusion. I'll be watching for how they play out in GitHub's runner configuration.
FWIW I've lifted that setup into the action declaration, to keep it from cluttering otherwise clean tests in the script.
With apologies — that wasn't my remit — I've tacked on a second commit that applies this same separation of concerns to other resources like ZFS and exec bits.
Also I think
apt-get update
and upgrade are supposed to be GitHub's problem, rather than counting against everybody's usage individually? I could be wrong on that; I'm mostly a self-hosted GitLab guy.