-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for most common nested elements in block quotes #49
base: master
Are you sure you want to change the base?
Conversation
I was excited to see your contribution @rmecham. I've tried this with an example from Gruber's markdown syntax page:
This renders as two separate blockquote elements, but I'd expect it to be just one. |
Thinking aloud: The PR also adds explicit code for other fragments inside the blockquote, checking for Ideally that code would be reused - but it might need part of
The |
I'll chime in and express my enthusiasm for this pull request. In particular, the idea of multiple
In fact we can see that's just what the GitHub markdown parser does, if you inspect the following element, you'll see it is transformed to a single blockquote:
I had to do some gymnastics with inserting |
This is definitely something that is needed in Ink. |
I've had a go at updating Ink to support what I think are the HTML elements most commonly nested inside block quotes. I'm relatively new to Swift, so please let me know if you have any comments or suggestions.