Fixed track change event not firing correctly

JohnnyCrazy · May 6, 2018 · 6646f8d · 6646f8d
1 parent 35b531e
commit 6646f8d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/SpotifyAPI/Local/Models/Track.cs b/SpotifyAPI/Local/Models/Track.cs
@@ -30,14 +30,7 @@ public class Track
         /// Checks if the track is an advert
         /// </summary>
         /// <returns>true if the track is an advert, false otherwise</returns>
-        public bool IsAd()
-        {
-            if (TrackType == "ad")
-                return true;
-            if (Length == 0)
-                return true;
-            return false;
-        }
+        public bool IsAd() => TrackType == "ad" || Length == 0;
 
         /// <summary>
         /// Checks if the track id of type "other"

diff --git a/SpotifyAPI/Local/SpotifyLocalAPI.cs b/SpotifyAPI/Local/SpotifyLocalAPI.cs
@@ -54,6 +54,7 @@ public ISynchronizeInvoke SynchronizingObject
         private readonly RemoteHandler _rh;
         private Timer _eventTimer;
         private StatusResponse _eventStatusResponse;
+        private Track _eventStatusTrack;
 
         public event EventHandler<TrackChangeEventArgs> OnTrackChange;
 
@@ -105,14 +106,14 @@ private void ElapsedTick(object sender, ElapsedEventArgs e)
                 _eventTimer.Start();
                 return;
             }
-            if (newStatusResponse.Track != null && _eventStatusResponse.Track != null)
+            if (newStatusResponse.Track != null && _eventStatusTrack != null)
             {
-                if (newStatusResponse.Track.TrackResource?.Uri != _eventStatusResponse.Track.TrackResource?.Uri ||
-                    newStatusResponse.Track.IsOtherTrackType() && newStatusResponse.Track.Length != _eventStatusResponse.Track.Length)
+                if (newStatusResponse.Track.TrackResource?.Uri != _eventStatusTrack.TrackResource?.Uri ||
+                    newStatusResponse.Track.IsOtherTrackType() && newStatusResponse.Track.Length != _eventStatusTrack.Length)
                 {
                     OnTrackChange?.Invoke(this, new TrackChangeEventArgs()
                     {
-                        OldTrack = _eventStatusResponse.Track,
+                        OldTrack = _eventStatusTrack,
                         NewTrack = newStatusResponse.Track
                     });
                 }
@@ -140,6 +141,10 @@ private void ElapsedTick(object sender, ElapsedEventArgs e)
                 });
             }
             _eventStatusResponse = newStatusResponse;
+            if (newStatusResponse.Track != null)
+            {
+                _eventStatusTrack = newStatusResponse.Track;
+            }
             _eventTimer.Start();
         }