First version of bitcoin core integration #555
Conversation
| return super(RegtestBitcoinCoreInterface, self).estimate_fee_per_kb(N) | ||
| else: | ||
| return jm_single().config.getint("POLICY", "absurd_fee_per_kb") + 100 | ||
| def estimate_fee_per_kb(self, N): |
There was a problem hiding this comment.
Seems to be 4 spaces-> 5 ? I think this might be why my editor complains about this particular file's formatting.
There was a problem hiding this comment.
This one line looks like it has 5 spaces instead of 4, so I'll fix that. I believed this is going from tab to 4 spaces.
|
I haven't had a chance to read it (I'm not as knowledgeable about Core internals as some other people around here anyway), but thanks for doing it. I get the basic idea. Have you been able to do any tests with Bitcoin-Qt? Does it show up correctly after broadcast? |
|
After broadcast the original non-coinjoin transaction gets market as the 'conflicted' state, this was known since walletbroadcast=0 was created bitcoin/bitcoin#5951 |
|
Changes Unknown when pulling 10f76b8 on bitcoind-int into * on develop*. |
|
Changes Unknown when pulling 4fcf12a on bitcoind-int into * on develop*. |
|
OK to merge with me to develop, if that's what you want to do. We'll need to re-merge it into 0.2.0 (and same for anything else we merge from now into dev) Congrats on getting it working :) |
AdamISZ
force-pushed
the
develop
branch
3 times, most recently
from
97d2603
to
47479d5
Compare
An implementation of #103
To use, run Bitcoin-Qt with walletbroadcast=0 along with all the other configurations for using JoinMarket with Bitcoin Core.
In case the coinjoin triggered by walletnotify fails, you can run this new script with a txid as an argument and it will attempt to create a coinjoin from it again.
It works by adding a hook to BitcoinCoreInterface which calls back on every walletnotify. The same thing can be used for implementing #253