Close iterating sdf reader in finally block

JonasSchaub · Dec 20, 2023 · 10cbf6a · 10cbf6a
1 parent 67ba808
commit 10cbf6a
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/.../org/openscience/cdk/tools/efgf/app/ErtlFunctionalGroupsFinderPerformanceSnapshotApp.java b/.../org/openscience/cdk/tools/efgf/app/ErtlFunctionalGroupsFinderPerformanceSnapshotApp.java
@@ -142,6 +142,7 @@ public ErtlFunctionalGroupsFinderPerformanceSnapshotApp(String[] anArgs) throws
         FileInputStream tmpDBFileInputStream = null;
         ExecutorService executor = null;
         PrintWriter tmpResultsPrintWriter = null;
+        IteratingSDFReader tmpDBReader = null;
         boolean tmpHasAnErrorOccurred = false;
         try {
             if (anArgs.length != 2) {
@@ -180,7 +181,7 @@ public ErtlFunctionalGroupsFinderPerformanceSnapshotApp(String[] anArgs) throws
             tmpResultsPrintWriter.println("Application initialized. Loading database file named " + anArgs[0] + ".");
             tmpResultsPrintWriter.flush();
             System.out.println("\nApplication initialized. Loading database file named " + anArgs[0] + ".");
-            IteratingSDFReader tmpDBReader = new IteratingSDFReader(tmpDBFileInputStream,
+            tmpDBReader = new IteratingSDFReader(tmpDBFileInputStream,
                     SilentChemObjectBuilder.getInstance(),
                     true);
             List<IAtomContainer> tmpMoleculesList = new LinkedList<>();
@@ -255,6 +256,9 @@ public ErtlFunctionalGroupsFinderPerformanceSnapshotApp(String[] anArgs) throws
             if (!Objects.isNull(tmpDBFileInputStream)) {
                 tmpDBFileInputStream.close();
             }
+            if (!Objects.isNull(tmpDBReader)) {
+                tmpDBReader.close();
+            }
             if (tmpHasAnErrorOccurred) {
                 System.exit(1);
             }