Corrected closing vs shutdown of executor service;

JonasSchaub · Jan 8, 2024 · 9ca388c · 9ca388c
1 parent 8b00af7
commit 9ca388c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml
@@ -22,7 +22,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        java: [ 11, 17, 21 ]
+        java: [ 8, 11, 17, 21 ]
     name: Java ${{ matrix.java }}
 
     steps:

diff --git a/.../org/openscience/cdk/tools/efgf/app/ErtlFunctionalGroupsFinderPerformanceSnapshotApp.java b/.../org/openscience/cdk/tools/efgf/app/ErtlFunctionalGroupsFinderPerformanceSnapshotApp.java
@@ -236,7 +236,7 @@ public ErtlFunctionalGroupsFinderPerformanceSnapshotApp(String[] anArgs) throws
             }
             tmpResultsPrintWriter.println(tmpExceptionsCounter + " molecules produced an exception.");
             tmpResultsPrintWriter.flush();
-            executor.close();
+            executor.shutdownNow();
             tmpResultsPrintWriter.println();
             tmpResultsPrintWriter.flush();
             tmpResultsPrintWriter.close();
@@ -248,7 +248,7 @@ public ErtlFunctionalGroupsFinderPerformanceSnapshotApp(String[] anArgs) throws
             }
         } finally {
             if (!Objects.isNull(executor)) {
-                executor.close();
+                executor.shutdownNow();
             }
             if (!Objects.isNull(tmpResultsPrintWriter)) {
                 tmpResultsPrintWriter.close();