-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 21 react examples to v18 #298
Update 21 react examples to v18 #298
Conversation
Things left to do here:
|
7325132
to
b7bf89f
Compare
I started using |
Perhaps because |
I think in PureScript one can use anything as props. From a react perspective props are a key value pairs and can be represented as html attributes. Therefore the empty record/object seems a bit more idiomatic than unit, undefined or null to me. I'd be open to changing if there is a reason to do so, but I think we're good to go as is :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andys8 Thank you so much for all your work on both this repo and in the Try PS repo.
Updated react hooks examples to render in
#root
to avoidbody
warning and use newcreateRoot
function to avoid deprecation warning.index.html
mkApp :: Component {}
in all examplesRoutingPushReactHooks
has a differentmain
function because ofrouterProvider
withReaderT
Examples
Related
createRoot
)Review
Actual diff (without formatting PR) can be better viewed by comparing this and the base branch