Skip to content

Commit

Permalink
prov/efa: Turn off medium protocol for Neuron
Browse files Browse the repository at this point in the history
This reverts commit 60d42a6.

Neuron messages should be sent via EAGER <MTU_SIZE, and with RUNTING
READ for >MTU_SIZE. The RUNTING READ protocol will work like a medium
protocol until the NIC is saturated, and then we want to do all future
sends using READ. The medium protocol will always "RUNT" all its data,
and that is not the correct thing to do.

Signed-off-by: Seth Zegelstein <[email protected]>
  • Loading branch information
a-szegel committed Feb 15, 2024
1 parent 9e33dc5 commit f9afb66
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
5 changes: 1 addition & 4 deletions prov/efa/src/efa.h
Original file line number Diff line number Diff line change
Expand Up @@ -102,15 +102,12 @@


#define EFA_DEFAULT_RUNT_SIZE (307200)
#define EFA_NEURON_RUNT_SIZE (131072)
#define EFA_DEFAULT_INTER_MAX_MEDIUM_MESSAGE_SIZE (65536)
#define EFA_DEFAULT_INTER_MIN_READ_MESSAGE_SIZE (1048576)
#define EFA_DEFAULT_INTER_MIN_READ_WRITE_SIZE (65536)
#define EFA_DEFAULT_INTRA_MAX_GDRCOPY_FROM_DEV_SIZE (3072)

#define EFA_NEURON_RUNT_SIZE (131072)
#define EFA_NEURON_INTER_MAX_MEDIUM_MESSAGE_SIZE (49152)
#define EFA_NEURON_INTER_MIN_READ_MESSAGE_SIZE (49152)

/*
* The default memory alignment
*/
Expand Down
4 changes: 2 additions & 2 deletions prov/efa/src/efa_hmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ static int efa_domain_hmem_info_init_protocol_thresholds(struct efa_domain *efa_
case FI_HMEM_NEURON:
info->runt_size = EFA_NEURON_RUNT_SIZE;
info->max_intra_eager_size = 0;
info->max_medium_msg_size = EFA_NEURON_INTER_MAX_MEDIUM_MESSAGE_SIZE;
info->min_read_msg_size = EFA_NEURON_INTER_MIN_READ_MESSAGE_SIZE;
info->max_medium_msg_size = 0;
info->min_read_msg_size = efa_max_eager_msg_size_with_largest_header(efa_domain) + 1;
info->min_read_write_size = efa_max_eager_msg_size_with_largest_header(efa_domain) + 1;
fi_param_get_size_t(&efa_prov, "runt_size", &info->runt_size);
fi_param_get_size_t(&efa_prov, "inter_min_read_message_size", &info->min_read_msg_size);
Expand Down

0 comments on commit f9afb66

Please sign in to comment.