Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a_diag only approximately equal to matrix because of roundoff #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vntmb
Copy link

@vntmb vntmb commented Sep 10, 2021

Notebook 11 - Factorizations and other fun.ipynb fails assertion for exercises 11.1 and 11.2 because the eigenvalues/diagonal matrix is only approximately equal to the given vector/matrix, due to numerical errors

@logankilpatrick
Copy link
Member

Is there a way to re-formulate this PR to not remove the entire notebook?

@logankilpatrick
Copy link
Member

Bumping this @vntmb

@vntmb vntmb force-pushed the a_diag_approx_equal branch from 829a5ab to 49078f9 Compare January 16, 2022 16:49
@vntmb
Copy link
Author

vntmb commented Jan 16, 2022

@logankilpatrick thanks for bumping the issue. the change has been made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants