-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a note about reinterpret
's memory layout
#199
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a84ff9c
add a note about `reinterpret`'s memory layout
johnnychen94 f30a9ab
rephrase the words
johnnychen94 3774918
apply suggestions
johnnychen94 bb5247d
move to advanced section
johnnychen94 75f7e1d
add example for dims keyword
johnnychen94 ae40727
one more note on `dims=ndims(v)`
johnnychen94 1469c84
explain the memory order and the view perspective
johnnychen94 7856ded
Minor wording change
piever File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I use
v = [1 3; 2 -1]
then I getIs this expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure? I get
which is the expected behavior. Btw,
dims=ndims(v)
would be the way to get contiguous views as component arrays (selecting on the last dimension).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry , I mean:
Interpreting the output is quite, hmmm, unintuitive. Maybe I just hit some undefined behaviors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see, it behaves a bit funny if the types don't match. It's probably because it has some logic to support nested cases, I've opened #200 to track this. Note that this constructor does not allocate, it can't use a matrix of integers to store components of
ComplexF64
.