Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move
StaticArrays
support to extension #265Move
StaticArrays
support to extension #265Changes from 4 commits
c81c308
7171bab
b0d509b
58a54f9
bc629da
0542152
02257b9
b4de96b
60a8c8c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 6 in ext/StructArraysAdaptExt.jl
Codecov / codecov/patch
ext/StructArraysAdaptExt.jl#L6
Check warning on line 11 in ext/StructArraysAdaptExt.jl
Codecov / codecov/patch
ext/StructArraysAdaptExt.jl#L8-L11
Check warning on line 55 in ext/StructArraysStaticArraysExt.jl
Codecov / codecov/patch
ext/StructArraysStaticArraysExt.jl#L54-L55
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part worries me a little bit, we are using something explicitly marked as internal in StaticArrays. Is there no way to achieve this using only public methods? Or maybe we could check over at StaticArrays if they can offer some solution (maybe add a public method that does what we need).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well
__broadcast
was splitted from_broadcast
in JuliaArrays/StaticArrays.jl#1001.So perhaps the best solution is defining it ourselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, thanks for pointing out that discussion. In that case, maybe one could just add a small docstring in
StaticArrays.__broadcast
to mention that it is the method to be used by outside packages to implement broadcasting of wrapped static arrays (in that way it doesn't accidentally get removed in some StaticArrays refactor that would accidentally break our code).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense too.
Anyway, there's not much code added here. Should we just merge this PR as is, and revert that specific commit once StaticArrays get that mention.
Check warning on line 61 in ext/StructArraysStaticArraysExt.jl
Codecov / codecov/patch
ext/StructArraysStaticArraysExt.jl#L61