Create documentation website and replace Formatting.jl #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently tests fail on Julia 1.3. The dependency Formatting.jl was replaced with Format.jl, which uses the ryu algorithm in Base, introduced in Julia 1.4. Suggest changing Julia compat rather than downgrading Format.jl compat |
|
Since this updates Julia's compat entry, a bump version commit should be added, and to 0.2.0 rather than 0.1.x because it's a breaking change. |
Breaking changes - Only supports julia v1.6 onwards - Use Format.jl instead of Formatting.jl
|
Using rebase+merge so that registrator can be triggered directly at the bump commit instead of the merge commit. |
|
Why is that relevant? |
|
If you mean the rebase, it's just so that the change can be pinned to a single delta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.