Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add methods for length and size of Row #13

Merged
merged 4 commits into from
Mar 30, 2021
Merged

add methods for length and size of Row #13

merged 4 commits into from
Mar 30, 2021

Conversation

visr
Copy link
Collaborator

@visr visr commented Mar 23, 2021

@visr
add methods for length and size of Row
50034a6
@visr
fix badges pointing to WeakRefStrings
afe1937 
This changes the CI badges from failing to passing and code coverage from 55% to 95%.
@visr visr requested a review from quinnj March 23, 2021 17:18
@quinnj
Copy link
Member

quinnj commented Mar 23, 2021

To make this a little more robust, I think we should have struct Row <: Tables.AbstractRow. Then we get length, getproperty, getindex, etc. all for free. The other changes needed then is to switch from defining propertynames, getproperty to defining Tables.columnnames and Tables.getcolumn. If you're up for that, it'd be a great improvement. I can also do it if you'd rather.

@visr
Copy link
Collaborator Author

visr commented Mar 23, 2021

Ah that sounds good, I wasn't aware of Tables.AbstractRow. I'll try it out in a few days.

@visr visr marked this pull request as draft March 23, 2021 21:09
@visr visr mentioned this pull request Mar 24, 2021
Open
@visr visr marked this pull request as ready for review March 30, 2021 15:42
@quinnj
Copy link
Member

quinnj commented Mar 30, 2021

@visr , anything else you wanted to add/change here? It LGTM. Should we merge & tag?

@visr
Copy link
Collaborator Author

visr commented Mar 30, 2021

Nope, merge and tag would be great!

@quinnj quinnj merged commit 98520b9 into main Mar 30, 2021
@quinnj quinnj deleted the size branch March 30, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@visr @quinnj