CompatHelper: bump compat for IntervalRootFinding to 0.6, (keep existing compat) #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
This is actually breaking. Must change See https://github.com/JuliaIntervals/IntervalRootFinding.jl/releases/tag/v0.6.0 |
Kolaru
reviewed
Nov 16, 2024
| ds = DeterministicIteratedMap(henon_rule, zeros(2), [1.4, 0.3]) | ||
| x = interval(-1.5, 1.5) | ||
| y = interval(-0.5, 0.5) | ||
| box = x × y | ||
| box = [x, y] |
There was a problem hiding this comment.
The problem is here: the initial vector must have the same type as the output of the function.
Since henon_rule and henon_jacob use SArrays, this should be a SVector (and same for the two other testsets below).
Datseris
deleted the
compathelper/new_version/2024-11-05-12-40-29-974-02757858420
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
IntervalRootFindingpackage from0.5.9to0.5.9, 0.6.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.