Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lenunit option to CSV loading #116

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Add lenunit option to CSV loading #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0476f91
Add 'lenunit' option to CSV loading
eliascarv Sep 23, 2024
5688e32
Update code
eliascarv Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ GeoFormatTypes = "0.4"
GeoInterface = "1.0"
GeoJSON = "0.8"
GeoParquet = "0.1, 0.2"
GeoTables = "1.21"
GeoTables = "1.23.13"
GslibIO = "1.5"
ImageCore = "0.10"
ImageIO = "0.6"
Expand Down
2 changes: 1 addition & 1 deletion src/extra/csv.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function csvread(fname; lenunit, coords, kwargs...)
end

srows = Tables.subset(rows, sinds)
georef(srows, cnames)
georef(srows, cnames; lenunit)
end

function csvwrite(fname, geotable; coords=nothing, floatformat=nothing, kwargs...)
Expand Down
4 changes: 4 additions & 0 deletions test/io/csv.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@
@test gtb2[1, :] == gtb1[1, :]
@test gtb2[2, :] == gtb1[3, :]
@test gtb2[3, :] == gtb1[5, :]

# custom lenunit
gtb = GeoIO.load(joinpath(datadir, "points.csv"), coords=["x", "y"], lenunit=cm)
@test unit(Meshes.lentype(crs(gtb.geometry))) == cm
end

@testset "save" begin
Expand Down
Loading