Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update regex to support multiline in julia-console #285

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pangoraw
Copy link
Member

@Pangoraw Pangoraw commented Jul 13, 2024

@adrhill
Copy link

adrhill commented Jul 23, 2024

Related issues: #282, #283

@adrhill
Copy link

adrhill commented Jul 23, 2024

@Pangoraw could you remind me how we tested this locally?

EDIT: GitHub linguist has a guide.

@Pangoraw
Copy link
Member Author

You need nodejs and npm installed:

cd atom-language-julia
npm ci # install dependencies described in package-lock.json (instantiate in julia)
npm run test

@Pangoraw
Copy link
Member Author

One think I am wondering is that maybe we should put the fix in the cson file and remove the json file since Github linguist seems to work fine with cson for now.

@pfitzseb
Copy link
Collaborator

Could also consider moving the source of truth into a template file like the actual julia grammar, but tbf it doesn't really make any sense except for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants