pin eccodes_jll=2.28 to make variable names stable #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #35
I think the best approach is to pin eccodes_jll to 2.28 and release GRIBDatasets 0.3.3. This would mean that user code should continue to work of anyone that have set compat GRIBDatasets=0.3 when they update their project.
After this is done, we can make a PR that pin eccodes_jll to 2.36 and release GRIBDatasets as 0.4. The variables names should be part of GRIBDatasets public interface and I therefore believe that bumping eccodes_jll versions should result in a breaking release.
In the future, we could make a breaking release to update eccodes_jll once a year or when we are doing a breaking release anyway.
Alternatively, eccodes_jll should be pinned in GRIB.jl if short names are considered a stable part of the interface there.
@Alexander-Barth @tcarion