Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ambiguity and implement getgeom, ngeom for Wrappers.Point #173

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asinghvi17
Copy link
Member

This was mentioned on Slack, the output is probably a bit better than a method ambiguity error now.

@rafaqz
Copy link
Member

rafaqz commented Oct 24, 2024

Not sure nothing is the best return value here.

We could also just return the point from getgeom and ngeom could be 1

Or error

@asinghvi17
Copy link
Member Author

Error might be best?

@rafaqz
Copy link
Member

rafaqz commented Oct 31, 2024

Error is pretty safe as we can always change it later, but returning nothing is permanent

@rafaqz
Copy link
Member

rafaqz commented Dec 13, 2024

Maybe GI.getgeom(point, 1) should return the point? a bit like how numbers work just returning themselves?

Then GI.ngeom(point) should return 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants