Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Makie extension #103

Merged
merged 6 commits into from
Jan 7, 2024
Merged

Add a Makie extension #103

merged 6 commits into from
Jan 7, 2024

Conversation

rafaqz
Copy link
Member

@rafaqz rafaqz commented Dec 27, 2023

This could be just regular code, but the extension should keep the overhead of GeoInterfaceMakie.jl even lower.

@rafaqz rafaqz changed the title Add a Makie ext Add a Makie extension Dec 27, 2023
@rafaqz
Copy link
Member Author

rafaqz commented Dec 27, 2023

This needs GeoInterfaceMakie v0.1.5 to come through

@rafaqz rafaqz requested a review from visr December 27, 2023 17:27
@rafaqz
Copy link
Member Author

rafaqz commented Dec 27, 2023

Do we need to keep anything below 1.9? I would prefer not to mess around with Revise.jl to make this work on 1.7 (or we can just not test Makie on 1.7, although its a little clunky to do that

@rafaqz rafaqz merged commit 7d245c8 into main Jan 7, 2024
16 checks passed
@rafaqz rafaqz deleted the makie_ext branch January 7, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant