Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute the cell area for an infinite polygon #15

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

AaronGhost
Copy link
Contributor

Add a new function cellarea to compute an InfinitePolygon area. The function deals with infinite cases, degenerate cases (reduced to a point, a segment) and the normal polygon case where the area is well defined with the shoelace method.

@dgleich
Copy link
Collaborator

dgleich commented Mar 1, 2024

This looks good! Thanks! Just waiting for tests to run.

@dgleich
Copy link
Collaborator

dgleich commented Mar 1, 2024

Looks like we are getting some test errors from Aqua/JET. I'll need to dig into those in a bit to see.

@dgleich
Copy link
Collaborator

dgleich commented Mar 1, 2024

The error is

Stale dependencies |    1      1  0.9s
Delaunator [466f8f70-d5e3-4806-ac0b-a54b75a91218] does not declare a compat entry for the following extras:
6-element Vector{Base.PkgId}:
 Aqua [4c88cf16-eb10-579e-8560-4a9242c79595]
 GeometryBasics [5c1252a2-5f33-56bf-86c9-59e7332b4326]
 JET [c3a54625-cd67-489e-a8e7-0a5a0ff4e31b]
 JSON [682c06a0-de6a-54ab-a142-c8b1cf79cde6]
 StableRNGs [860ef19b-820b-49d6-a774-d7a799459cd3]
 Test [8dfed614-e22c-5e08-85e1-65c5234f0b40]
Delaunator [466f8f70-d5e3-4806-ac0b-a54b75a91218] extras: Test Failed at /Users/dgleich/.julia/packages/Aqua/9p8ck/src/deps_compat.jl:60
  Expression: isempty(result)
   Evaluated: isempty(Base.PkgId[Aqua [4c88cf16-eb10-579e-8560-4a9242c79595], GeometryBasics [5c1252a2-5f33-56bf-86c9-59e7332b4326], JET [c3a54625-cd67-489e-a8e7-0a5a0ff4e31b], JSON [682c06a0-de6a-54ab-a142-c8b1cf79cde6], StableRNGs [860ef19b-820b-49d6-a774-d7a799459cd3], Test [8dfed614-e22c-5e08-85e1-65c5234f0b40]])
Stacktrace:

@dgleich
Copy link
Collaborator

dgleich commented Mar 1, 2024

Ah - I think this is because the extras are all used just for testing, so we should move them to the test repo?

@AaronGhost
Copy link
Contributor Author

The tests with Aqua already don't passed on master. I opened a new PR #16 to fix the tests on master.

@dgleich dgleich merged commit fe3ab83 into JuliaGeometry:master Apr 16, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants