Skip to content

Commit

Permalink
Remove obsolete code
Browse files Browse the repository at this point in the history
  • Loading branch information
mikeingold committed Nov 11, 2024
1 parent 762b4bb commit 98732f1
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 10 deletions.
6 changes: 0 additions & 6 deletions src/specializations/Tetrahedron.jl
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,6 @@ function _parametric(tetrahedron::Meshes.Tetrahedron, t1, t2, t3)
@assert (0 <= t3 <= 1)

# Take a triangular cross-section at t3
#=
rem = _constrain(1 - t3)
a = tetrahedron(0, 0, t3)
b = tetrahedron(0, rem, t3)
c = tetrahedron(rem, 0, t3)
=#
a = tetrahedron(t3, 0, 0)
b = tetrahedron(0, t3, 0)
c = tetrahedron(0, 0, t3)
Expand Down
2 changes: 1 addition & 1 deletion src/specializations/Triangle.jl
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ end
function _parametric(triangle::Meshes.Triangle, t1, t2)
@assert (0 <= t1 <= 1) && (0 <= t2 <= 1)

# Form a horizontal line segment at t2
# Form a line segment between sides
a = triangle(0, t2)
b = triangle(t2, 0)
segment = Meshes.Segment(a, b)
Expand Down
3 changes: 0 additions & 3 deletions src/utils.jl
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ function _error_unsupported_combination(geometry, rule)
throw(ArgumentError(msg))
end

# TODO test new version of parametric that doesn't require this
_constrain(t) = (t > 0) ? prevfloat(t) : t

################################################################################
# DifferentiationMethod
################################################################################
Expand Down

0 comments on commit 98732f1

Please sign in to comment.