Skip to content

Commit

Permalink
Add testing with ExplicitImports.jl (#90)
Browse files Browse the repository at this point in the history
* add tests with ExplicitImports.jl

* add newline at end of file

* add some more tests

* bump lower compat of ExplicitImport.jl

* import × from Meshes.jl

* import ⋅ from Meshes.jl

* Move cross and dot imports to LA

---------

Co-authored-by: Michael Ingold <[email protected]>
  • Loading branch information
JoshuaLampert and mikeingold authored Sep 25, 2024
1 parent fb671d8 commit d784136
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/MeshIntegrals.jl
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module MeshIntegrals
using CoordRefSystems
using LinearAlgebra
using Meshes
using Unitful
using CoordRefSystems: CoordRefSystems, CRS
using LinearAlgebra: LinearAlgebra, I, norm, ×,
using Meshes: Meshes, Line, Plane, Ray, area, degree, plane, segments, volume
using Unitful: Unitful

import FastGaussQuadrature
import HCubature
Expand Down
2 changes: 2 additions & 0 deletions test/Project.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
[deps]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
Meshes = "eacbb407-ea5a-433e-ab97-5258b1ca43fa"
QuadGK = "1fd47b50-473d-5c70-9696-f719f8f3bcdc"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Expand All @@ -9,6 +10,7 @@ Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"

[compat]
Aqua = "0.7, 0.8"
ExplicitImports = "1.6.0"
Meshes = "0.50, 0.51"
QuadGK = "2.1.1"
TestItemRunner = "1"
Expand Down
14 changes: 14 additions & 0 deletions test/aqua.jl
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,17 @@
# - Verified that no ambiguities exist within MeshIntegrals.jl
Aqua.test_all(MeshIntegrals; ambiguities = false)
end

@testitem "ExplicitImports.jl" begin
using ExplicitImports: check_no_implicit_imports, check_no_stale_explicit_imports,
check_all_explicit_imports_via_owners,
check_all_explicit_imports_are_public,
check_all_qualified_accesses_via_owners,
check_no_self_qualified_accesses
@test isnothing(check_no_implicit_imports(MeshIntegrals))
@test isnothing(check_no_stale_explicit_imports(MeshIntegrals))
@test isnothing(check_all_explicit_imports_via_owners(MeshIntegrals))
@test isnothing(check_all_explicit_imports_are_public(MeshIntegrals))
@test isnothing(check_all_qualified_accesses_via_owners(MeshIntegrals))
@test isnothing(check_no_self_qualified_accesses(MeshIntegrals))
end

0 comments on commit d784136

Please sign in to comment.