-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for Ellipsoid
and Hexahedron
#102
Conversation
Just as a note: The link behind the 🎗️ in the docs doesn't seem to work. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 258 260 +2
=========================================
+ Hits 258 260 +2 ☔ View full report in Codecov by Sentry. |
Ah, I see why. The result of julia> using Meshes, MeshIntegrals
julia> origin = Point(0, 0, 0)
Point with Cartesian{NoDatum} coordinates
├─ x: 0.0 m
├─ y: 0.0 m
└─ z: 0.0 m
julia> radii = (1.0, 1.0, 1.0)
(1.0, 1.0, 1.0)
julia> ellipsoid = Ellipsoid(radii, origin)
Ellipsoid
├─ radii: (1.0 m, 1.0 m, 1.0 m)
├─ center: Point(x: 0.0 m, y: 0.0 m, z: 0.0 m)
└─ rotation: LinearAlgebra.UniformScaling{Bool}(true)
julia> using Unitful: m
julia> 4pi*m^2 - measure(ellipsoid)
0.02225157793214194 m^2
julia> 4pi*m^2 - integral(f, ellipsoid, GaussLegendre(100))
-4.96278573791642e-11 m^2 The result from |
Exactly. This is something I've definitely seen. When there's no analytic solution defined for measure, Meshes will |
Once the overall goal to test against analytical solutions for non-trivial functions is achieved in the future, we will not depend on |
Just as a note: The link behind the 🎗️ in the docs doesn't seem to work.
Weird. It looks like the Documenter site's `stable` version is stale and
hasn't been updated since ~v13.2. The pages under `dev` are up to date,
though. Have you ever seen this kind of thing happen before?
…On Wed, Oct 9, 2024 at 1:04 PM Joshua Lampert ***@***.***> wrote:
Once the overall goal to test against analytical solutions is achieved in
the future, we will not depend on measure anyway.
—
Reply to this email directly, view it on GitHub
<#102 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA657OWQVEMHK4B7RCK6HKDZ2VOYHAVCNFSM6AAAAABPUZPOG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBSHA2TGOJVGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Indeed. I don't know why this is and I don't see anything suspicious in the logs. |
We don't have to hold up this PR over it. I just added #103 for tracking. |
Integrating
Ellipsoid
andHexahedron
should simply work. However, I needed to set pretty high tolerances forEllipsoid
for some reason. Do you know why @mikeingold?I also added other geometries, which do not implement any parametric function yet, in the support matrix, cf. #57