-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement benchmarking with AirspeedVelocity.jl #119
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 17 17
Lines 259 259
=======================================
Hits 248 248
Misses 11 11 ☔ View full report in Codecov by Sentry. |
@JoshuaLampert, this seems to work well on my system and should provide us with benchmarks to quantify performance impacts of each PR. The Action script is taken straight from AirspeedVelocity.jl; I don't see any blatant red flags, but you're more knowledgeable in that domain than I am. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks quite neat! I would like to see the action already running for this PR. Normally GitHub already runs newly added actions already in the PR, where they are added. So let's see if fixing the pull_request_target
branch runs the action.
It still doesn't run. I'm not sure why. |
Ahh, there we go. Now it runs, but fails. Let me fix that quickly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some old versions.
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Everything runs fine now. Also uploading the plots works and updating the comment after a new push works nicely. |
Co-authored-by: Joshua Lampert <[email protected]>
Thanks for getting this working! |
Changes
@benchmark
entries, testing integrals ofSegment
andSphere
(surface),jacobian
, anddifferential
.Closes #21