Add BézierCurve to benchmarks (#124) #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Bézier entry * Missing comma, added newline * Make item implicitly Unitful * Make test item explicit to avoid reference errors * Formatting * Reformat range * Apply format suggestion Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mikeingold
added a commit
that referenced
this pull request
Nov 8, 2024
#122) * Add JacobianMethod types * Change JacobianMethod to DifferentiationMethod * Add a third argument to jacobian for DiffMethod for dispatch * Remove dead line * Remove obsolete analytic jacobian for BezierCurve * Add default step size if unspecified * Convert differential to three-argument with default FiniteDiff method * Bigfix * Add two-arg Jacobian pointing to FD * Apply formatting suggestion Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Apply suggestion Co-authored-by: Joshua Lampert <[email protected]> * Add a dt argument * Update docstring API * Add dt kwargs * Add missing params * Add dt kwargs (with TODOs) * Consolidate kwarg naming * Update src/differentiation.jl Co-authored-by: Joshua Lampert <[email protected]> * Add exports * Tweak suggested naming [skip CI] * Update Line methods to use an internal differential method * Bump version to v0.16.0-DEV * Add block for DifferentiationMethods * Drop abstract type * Add diff_method arguments * Change dt to diff_method * Prepare to revert jacobian of BezierCurve (pending new benchmarks) * Bump CI * Add BézierCurve to benchmarks (#124) (#126) * Add Bézier entry * Missing comma, added newline * Make item implicitly Unitful * Make test item explicit to avoid reference errors * Formatting * Reformat range * Apply format suggestion --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Reduce scald * Activate specialized Jacobian * Define an Analytic method and update jacobian of Bezier to it * Typo [skip CI] * Typo * Update src/specializations/BezierCurve.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Implement has_analytic * Bugfix * Enable analytical for BezierCurve [skip CI] * Implement default_method * Fix arg definition * Update arg type * Add methods on instances and types * Add tests for DifferentiationMethods * Use default_method in _integral methods * Use default_method in Bezier methods, improve docstring * Improve docstrings * Explicit namespace for test of non-exported function * Fix typo * Fix copy/paste error * Add tests for default_method * Type vs instance * Export Analytical * Typo * Typo * Parameterize Bezier type * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Redefine Line, Plane, and Ray specializations as Analytical * Redefine Triangle and Tetrahedron specializations as Analytical * Try new solution (cant dispatch on kwarg types) * Add jacobian code sections * Add guarantees * Move new utilities to utils and rename with prefix underscore * Typo * Update tests * Update name * Update function name * Update comment * Update name * Add better docstrings * Bugfix - error not actually thrown * Split DifferentiationMethod into separate testitem * Tweak include order * Formatting changes * Remove redundant docstrings * Add docstrings for Ring and Rope, update for Bezier * Apply suggestions from code review Co-authored-by: Joshua Lampert <[email protected]> * (WIP) Add a new kwarg section under Usage * Clarify Usage section * Formatting * Add a WIP differential forms explainer * Rename page and add some structure * Add new page to directory * Update index page with README contents * Update first two sections * Finished version 0 of How It Works * Move How it Works into new Dev Notes section * Properly enforce FiniteDiff FP rules * Bugfix - restore G param * Bugfix - tuple to ntuple * Remove Unicode from math blocks * New default constructors for FiniteDifference * Implement two-arg _default_method with FP type * Reorder kwargs and switch FP to T * Revert to single-arg _default_method * Change jacobian parameterization * Remove ununsed type param * Remove unneeded type param * Remove remnant two-arg default call * Clarify _guarantee_analytical arg types * Test externalizing partial derivative function * Re-internalize partial derivative function * Remove errant character * Apply format suggestions [skip ci] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Apply suggestions from code review [skip ci] Co-authored-by: Joshua Lampert <[email protected]> * Apply suggestions from code review Co-authored-by: Joshua Lampert <[email protected]> * Try new parameterization * Remove obsolete comment * Apply suggestions from code review Co-authored-by: Joshua Lampert <[email protected]> * Consolidate information on specializations * Apply suggestion * Apply suggestion Co-authored-by: Joshua Lampert <[email protected]> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Joshua Lampert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Bézier entry
Missing comma, added newline
Make item implicitly Unitful
Make test item explicit to avoid reference errors
Formatting
Reformat range
Apply format suggestion