Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new KVector Unitful extension to simplify differential #130

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

mikeingold
Copy link
Collaborator

Changes

  • Increases minimum compat version of CliffordNumbers.jl dependency to v0.1.9
  • Uses CliffordNumbers.jl's new Unitful extension, converting Meshes.Vec to Unitful.Quantity{KVector} which now support unit-aware wedge products
  • Add a new utility method _units(::Meshes.Vec)

Note: started new branch after difficulty git rebase-ing in #114.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (05238b2) to head (8105b71).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   95.26%   95.81%   +0.55%     
==========================================
  Files          17       17              
  Lines         380      287      -93     
==========================================
- Hits          362      275      -87     
+ Misses         18       12       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Benchmark Results

main 8105b71... main/8105b716d3f24d...
Differentials/Differential 0.249 ± 0.003 μs 0.241 ± 0.0011 μs 1.03
Differentials/Jacobian 0.206 ± 0.001 μs 0.206 ± 0.0001 μs 1
Integrals/Meshes.BezierCurve/Scalar GaussKronrod 22 ± 0.075 ms 23 ± 0.075 ms 0.958
Integrals/Meshes.BezierCurve/Scalar GaussLegendre 21.1 ± 0.062 ms 22 ± 0.054 ms 0.961
Integrals/Meshes.BezierCurve/Scalar HAdaptiveCubature 22.2 ± 0.03 ms 23.2 ± 0.08 ms 0.956
Integrals/Meshes.BezierCurve/Vector GaussKronrod 22 ± 0.043 ms 23 ± 0.095 ms 0.957
Integrals/Meshes.BezierCurve/Vector GaussLegendre 21.1 ± 0.033 ms 22 ± 0.043 ms 0.957
Integrals/Meshes.BezierCurve/Vector HAdaptiveCubature 22.2 ± 0.041 ms 23.2 ± 0.079 ms 0.957
Integrals/Meshes.Segment/Scalar GaussKronrod 1.2 ± 0.008 μs 1.26 ± 0.005 μs 0.95
Integrals/Meshes.Segment/Scalar GaussLegendre 0.0562 ± 0.00088 ms 0.0549 ± 0.00079 ms 1.02
Integrals/Meshes.Segment/Scalar HAdaptiveCubature 4.57 ± 0.064 μs 4.57 ± 0.053 μs 0.998
Integrals/Meshes.Segment/Vector GaussKronrod 3.43 ± 0.064 μs 3.39 ± 0.058 μs 1.01
Integrals/Meshes.Segment/Vector GaussLegendre 0.0663 ± 0.00083 ms 0.0677 ± 0.00099 ms 0.98
Integrals/Meshes.Segment/Vector HAdaptiveCubature 7.48 ± 0.14 μs 7.46 ± 0.11 μs 1
Integrals/Meshes.Sphere/Scalar GaussKronrod 0.087 ± 0.00046 ms 0.0882 ± 0.0019 ms 0.986
Integrals/Meshes.Sphere/Scalar GaussLegendre 12.3 ± 0.092 ms 12 ± 0.13 ms 1.03
Integrals/Meshes.Sphere/Scalar HAdaptiveCubature 0.0635 ± 0.00022 ms 0.0631 ± 0.00031 ms 1.01
Integrals/Meshes.Sphere/Vector GaussKronrod 0.12 ± 0.00095 ms 0.119 ± 0.001 ms 1.01
Integrals/Meshes.Sphere/Vector GaussLegendre 13.7 ± 0.4 ms 13.5 ± 0.46 ms 1.01
Integrals/Meshes.Sphere/Vector HAdaptiveCubature 0.113 ± 0.0014 ms 0.113 ± 0.0012 ms 1
time_to_load 1.66 ± 0.021 s 1.65 ± 0.0077 s 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@mikeingold mikeingold marked this pull request as ready for review November 8, 2024 19:01
Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikeingold mikeingold merged commit a10ed11 into main Nov 8, 2024
12 checks passed
@JoshuaLampert JoshuaLampert deleted the clifford2 branch November 9, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants