-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize integrand f
to any callable
#137
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
=======================================
Coverage 95.86% 95.86%
=======================================
Files 17 17
Lines 290 290
=======================================
Hits 278 278
Misses 12 12 ☔ View full report in Codecov by Sentry. |
The codecov/patch test fails because these changes touch the Tetrahedron methods, whose tests are currently tagged under extended/local-only testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Changes
f
be of typeFunction
f
to any callable #132struct
as integrand.