Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default arch in CI #144

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Use default arch in CI #144

merged 1 commit into from
Dec 2, 2024

Conversation

JoshuaLampert
Copy link
Member

There are warnings (e.g., https://github.com/JuliaGeometry/MeshIntegrals.jl/actions/runs/12112016118?pr=139) in the CI runs because we request x64 on a macOS runner with arm64. I propose to simply use the default architecture, i.e. to remove the arch argument. For the flag-name of the coveralls action I followed the example under coverallsapp/github-action#complete-parallel-job-example.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a375579) to head (8f9c4e2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #144   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          284       284           
=========================================
  Hits           284       284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Benchmark Results

main 8f9c4e2... main/8f9c4e2e0af8c3...
Differentials/Differential 0.239 ± 0.0011 μs 0.24 ± 0.0011 μs 0.996
Differentials/Jacobian 0.204 ± 0.001 μs 0.206 ± 0.001 μs 0.99
Integrals/Segment/Scalar GaussKronrod 1.2 ± 0.0051 μs 1.2 ± 0.008 μs 0.998
Integrals/Segment/Scalar GaussLegendre 9.2 ± 0.2 μs 8.57 ± 0.2 μs 1.07
Integrals/Segment/Scalar HAdaptiveCubature 1.47 ± 0.16 μs 1.46 ± 0.16 μs 1
Integrals/Segment/Vector GaussKronrod 3.43 ± 0.068 μs 3.44 ± 0.059 μs 0.997
Integrals/Segment/Vector GaussLegendre 24.6 ± 0.61 μs 25 ± 0.57 μs 0.983
Integrals/Segment/Vector HAdaptiveCubature 4.37 ± 0.086 μs 4.59 ± 0.091 μs 0.951
Integrals/Sphere/Scalar GaussKronrod 0.0818 ± 0.0019 ms 0.082 ± 0.002 ms 0.998
Integrals/Sphere/Scalar GaussLegendre 2.26 ± 0.0088 ms 2.27 ± 0.0095 ms 0.994
Integrals/Sphere/Scalar HAdaptiveCubature 0.0584 ± 0.00012 ms 0.0582 ± 9.9e-05 ms 1
Integrals/Sphere/Vector GaussKronrod 0.116 ± 0.00089 ms 0.116 ± 0.00089 ms 1
Integrals/Sphere/Vector GaussLegendre 3.68 ± 0.064 ms 3.64 ± 0.061 ms 1.01
Integrals/Sphere/Vector HAdaptiveCubature 0.109 ± 0.00096 ms 0.113 ± 0.0011 ms 0.961
Specializations/Scalar GaussLegendre/BezierCurve 0.249 ± 0.0028 ms 0.25 ± 0.0031 ms 0.994
Specializations/Scalar GaussLegendre/Line 10.2 ± 0.41 μs 10.4 ± 0.43 μs 0.986
Specializations/Scalar GaussLegendre/Plane 0.515 ± 0.0037 ms 0.515 ± 0.0036 ms 1
Specializations/Scalar GaussLegendre/Ray 6.33 ± 0.12 μs 6.29 ± 0.14 μs 1.01
Specializations/Scalar GaussLegendre/Triangle 0.71 ± 0.019 ms 0.692 ± 0.018 ms 1.03
time_to_load 1.49 ± 0.013 s 1.49 ± 0.022 s 0.998

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@mikeingold
Copy link
Collaborator

LGTM

@JoshuaLampert JoshuaLampert merged commit 6c67fca into main Dec 2, 2024
11 of 12 checks passed
@JoshuaLampert JoshuaLampert deleted the arch-ci branch December 2, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants