Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify spelling of "parametrize" #150

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Unify spelling of "parametrize" #150

merged 1 commit into from
Dec 4, 2024

Conversation

mikeingold
Copy link
Collaborator

Changes

@mikeingold mikeingold added the documentation Improvements or additions to documentation label Dec 4, 2024
@mikeingold mikeingold linked an issue Dec 4, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ab712c7) to head (f1f2dad).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #150   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          165       165           
=========================================
  Hits           165       165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Benchmark Results

main f1f2dad... main/f1f2dad3adc9f8...
Differentials/Differential 0.24 ± 0.0011 μs 0.24 ± 0.0019 μs 0.996
Differentials/Jacobian 0.205 ± 0.001 μs 0.206 ± 0.001 μs 0.995
Integrals/Segment/Scalar GaussKronrod 1.19 ± 0.0091 μs 1.2 ± 0.0081 μs 0.993
Integrals/Segment/Scalar GaussLegendre 4.16 ± 0.017 μs 4.23 ± 0.12 μs 0.984
Integrals/Segment/Scalar HAdaptiveCubature 1.54 ± 0.18 μs 1.46 ± 0.16 μs 1.06
Integrals/Segment/Vector GaussKronrod 3.48 ± 0.069 μs 3.54 ± 0.18 μs 0.981
Integrals/Segment/Vector GaussLegendre 20.3 ± 0.6 μs 20.5 ± 0.73 μs 0.988
Integrals/Segment/Vector HAdaptiveCubature 4.4 ± 0.097 μs 4.54 ± 0.16 μs 0.969
Integrals/Sphere/Scalar GaussKronrod 0.0815 ± 0.0023 ms 0.0831 ± 0.0018 ms 0.981
Integrals/Sphere/Scalar GaussLegendre 2.26 ± 0.0089 ms 2.25 ± 0.0095 ms 1
Integrals/Sphere/Scalar HAdaptiveCubature 0.0582 ± 0.00025 ms 0.0598 ± 0.00017 ms 0.973
Integrals/Sphere/Vector GaussKronrod 0.116 ± 0.002 ms 0.116 ± 0.0088 ms 0.998
Integrals/Sphere/Vector GaussLegendre 3.66 ± 0.1 ms 3.67 ± 0.11 ms 0.996
Integrals/Sphere/Vector HAdaptiveCubature 0.109 ± 0.0015 ms 0.109 ± 0.0016 ms 0.998
Rules/GaussLegendre 21.9 ± 0.47 μs 22.5 ± 1.2 μs 0.975
Specializations/Scalar GaussLegendre/BezierCurve 0.244 ± 0.00036 ms 0.245 ± 0.00032 ms 0.999
Specializations/Scalar GaussLegendre/Line 8.16 ± 0.49 μs 8.25 ± 0.14 μs 0.989
Specializations/Scalar GaussLegendre/Plane 0.9 ± 0.006 ms 0.897 ± 0.0067 ms 1
Specializations/Scalar GaussLegendre/Ray 7.67 ± 0.088 μs 7.49 ± 0.096 μs 1.02
Specializations/Scalar GaussLegendre/Rope 0.13 ± 0.00029 ms 0.128 ± 0.00028 ms 1.01
Specializations/Scalar GaussLegendre/Tetrahedron 0.304 ± 0.0032 s 0.3 ± 0.0045 s 1.01
Specializations/Scalar GaussLegendre/Triangle 0.726 ± 0.0054 ms 0.726 ± 0.0055 ms 1
time_to_load 1.65 ± 0.039 s 1.6 ± 0.054 s 1.03

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mikeingold mikeingold merged commit 301bcff into main Dec 4, 2024
12 checks passed
@mikeingold mikeingold deleted the metrize branch December 4, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameterized or Parametrized?
2 participants