Use hcubature_buffer for decomposed geometries
#157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+41
to
+45
| f, | ||
| rope::Meshes.Rope, | ||
| rule::HAdaptiveCubature; | ||
| FP::Type{T} = Float64, | ||
| kwargs... |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| f, | |
| rope::Meshes.Rope, | |
| rule::HAdaptiveCubature; | |
| FP::Type{T} = Float64, | |
| kwargs... | |
| f, | |
| rope::Meshes.Rope, | |
| rule::HAdaptiveCubature; | |
| FP::Type{T} = Float64, | |
| kwargs... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 184 206 +22
=========================================
+ Hits 184 206 +22 ☔ View full report in Codecov by Sentry. |
|
Using this technique seems to be marginally slower for a I'm going to try some other geometries to see if any others get any benefit. |
Comment on lines
+36
to
+41
| f, | ||
| cyl::Meshes.CylinderSurface, | ||
| rule::HAdaptiveCubature; | ||
| FP::Type{T} = Float64, | ||
| diff_method::DM = _default_diff_method(cyl, FP), | ||
| kwargs... |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| f, | |
| cyl::Meshes.CylinderSurface, | |
| rule::HAdaptiveCubature; | |
| FP::Type{T} = Float64, | |
| diff_method::DM = _default_diff_method(cyl, FP), | |
| kwargs... | |
| f, | |
| cyl::Meshes.CylinderSurface, | |
| rule::HAdaptiveCubature; | |
| FP::Type{T} = Float64, | |
| diff_method::DM = _default_diff_method(cyl, FP), | |
| kwargs... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
HCubature.hcubature_bufferto pre-allocate a buffer that can be re-used.Conclusion
Performance did not improve when using this for
RopeorCylinderSurface.