Add downgrade action #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 90.35% 90.35%
=======================================
Files 16 16
Lines 311 311
=======================================
Hits 281 281
Misses 30 30 ☔ View full report in Codecov by Sentry. |
|
Interesting that it required those specific minimum versions for Unitful and QuadGK, but they're not overly restrictive and I guess that's why we have the tool now. LGTM. |
mikeingold
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed I added a workflow for automatically testing the lower compat bounds. This workflow runs the test with all lower bounds given in the Project.toml. This is considered good practice and helps to keep the compat bounds valid. Running it locally revealed some unsatisfiable requirements, which I fixed by adjusting the lower compat bounds accordingly.