-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.14-DEV: Remove derivative
and unitdirection
from exports
#88
Conversation
derivative
and unitdirection
from exports
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
=======================================
Coverage 90.50% 90.50%
=======================================
Files 16 16
Lines 316 316
=======================================
Hits 286 286
Misses 30 30 ☔ View full report in Codecov by Sentry. |
Why is |
The For now, I wound up just implementing an inelegant but reasonably effective finite difference approximation within |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for the explanation. If you think jacobian
is reasonably stable and could be useful in its own, I'm fine exporting it (although I think it's a bit tangential to the goal of the package).
Completed
derivative
andunitdirection
from exports. These functions were developed early on when the direction of this package wasn't fully clear, and onlyBezierCurve
-specific methods were added. In the long-term, I'd like to implement a more robust system for calculating derivatives and Jacobians, ideally using automatic differentiation. I'm removing these from the public API to facilitate future experimentation but won't remove them from the package entirely.