Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code comments justifying use of specialized methods #89

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

mikeingold
Copy link
Collaborator

@mikeingold mikeingold commented Sep 25, 2024

Completed

  • Added comment blocks to each specialized source file explaining why specialized methods were required for each particular geometry type.

Overall v0.14-DEV roadmap being tracked in #84

@mikeingold mikeingold changed the title v0.14-DEV: Add code comments justifying use of specialized methods Add code comments justifying use of specialized methods Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (0a6eaaf) to head (4e72ccb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   90.50%   90.50%           
=======================================
  Files          16       16           
  Lines         316      316           
=======================================
  Hits          286      286           
  Misses         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeingold mikeingold marked this pull request as ready for review September 25, 2024 17:38
Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! That really helps!

@JoshuaLampert JoshuaLampert merged commit d27fa22 into main Sep 25, 2024
15 checks passed
@JoshuaLampert JoshuaLampert deleted the whyspecial branch September 25, 2024 18:04
@JoshuaLampert JoshuaLampert added the documentation Improvements or additions to documentation label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants