Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add box and laplacian2d #226

Merged
merged 3 commits into from
Sep 5, 2021
Merged

Add box and laplacian2d #226

merged 3 commits into from
Sep 5, 2021

Conversation

timholy
Copy link
Member

@timholy timholy commented Sep 4, 2021

These come from Images.jl and are part of moving most/all code
out to make it a meta-package.

As annotated in JuliaImages/Images.jl#971, these may be the last of the moves here (gaussian_pyramid does not seem likely to move). Consequently, once this merges we could release a new version, unblocking JuliaImages/ImageSegmentation.jl#72, or we could wait for #214 and/or #225.

These come from Images.jl and are part of moving most/all code
out to make it a meta-package.
@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #226 (e12a6ad) into master (02407fa) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files          11       11           
  Lines        1513     1513           
=======================================
  Hits         1386     1386           
  Misses        127      127           
Impacted Files Coverage Δ
src/kernel.jl 99.21% <100.00%> (+0.03%) ⬆️
src/kernelfactors.jl 90.97% <100.00%> (+0.25%) ⬆️
src/ImageFiltering.jl 68.75% <0.00%> (-8.53%) ⬇️
src/utils.jl 87.87% <0.00%> (-0.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02407fa...e12a6ad. Read the comment docs.

@timholy timholy force-pushed the teh/more_images_cleanout branch from 220d27d to 5ed6c11 Compare September 4, 2021 14:26
Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As annotated in JuliaImages/Images.jl#971, these may be the last of the moves here (gaussian_pyramid does not seem likely to move)

👍

src/kernel.jl Show resolved Hide resolved
src/kernel.jl Show resolved Hide resolved
test/specialty.jl Show resolved Hide resolved
@timholy timholy merged commit 6b51789 into master Sep 5, 2021
@timholy timholy deleted the teh/more_images_cleanout branch September 5, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants