Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Fix for macros without parameters #18

Merged
merged 1 commit into from
Jan 27, 2016
Merged

Fix for macros without parameters #18

merged 1 commit into from
Jan 27, 2016

Conversation

omus
Copy link
Member

@omus omus commented Dec 4, 2015

Previously macros such as @__FILE__ would not have permalinks since they did not include parenthesis. Not only was this annoying for cross-referencing but it made searching difficult as searching for @__FILE__ would result in no results.

Note however that parenthesis will automatically be added to macros without them in the rendered documentation. Ideally these would not be added.

Previously macros such as `@__FILE__` would not have permalinks since
they did not include parenthesis. Not only was this annoying for cross-
referencing but it made searching difficult as searching for `@__FILE__`
would result in no search results.

Note: Parenthesis will automatically be added to macros without them in
the rendered documentation.
@omus
Copy link
Member Author

omus commented Dec 4, 2015

The current change also now allows for a normal function without parentheses but includes the return annotation. Previously you could only get the return annotation if you included the use of parentheses.

@omus
Copy link
Member Author

omus commented Dec 4, 2015

Additionally fixes #7

@omus
Copy link
Member Author

omus commented Dec 11, 2015

@nolta can you take a look?

@omus
Copy link
Member Author

omus commented Jan 27, 2016

@tkelman could you take a look at this?

@tkelman
Copy link
Contributor

tkelman commented Jan 27, 2016

I guess this regex change looks safe, though I don't entirely know how this repo and the readthedocs setup work. There's nothing julia-version-specific about this, right? I guess we merge, adjust the sha in the doc virtualenv requirements file, and see if it looks right?

tkelman added a commit that referenced this pull request Jan 27, 2016
Fix for macros without parameters
@tkelman tkelman merged commit fe34306 into JuliaLang:master Jan 27, 2016
@omus
Copy link
Member Author

omus commented Jan 27, 2016

Thanks @tkelman. No there is nothing Julia version specific about this. I believe updating the doc/requirements.txt file is all we need to do. Do you want me to open a PR with that change?

@tkelman
Copy link
Contributor

tkelman commented Jan 27, 2016

If you feel so inclined, sure.

On Wed, Jan 27, 2016 at 9:24 AM -0800, "Curtis Vogt" [email protected] wrote:

Thanks @tkelman. No there is nothing Julia version specific about this. I believe updating the doc/requirements.txt file is all we need to do. Do you want me to open a PR with that change?


Reply to this email directly or view it on GitHub:
#18 (comment)

omus added a commit to omus/julia that referenced this pull request Jan 27, 2016
@omus omus deleted the macro branch February 1, 2016 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants