-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark the _state field as atomic and move to proper atomics instead of llvmcall #55502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
domain:multithreading
Base.Threads and related functionality
status:merge me
PR is reviewed. Merge when all tests are passing
labels
Aug 15, 2024
looks relevant |
Fixes #55125 (comment) See #55125 in general for which tests to update. I think you need to simply adjust the serialization code to also use an atomic here. |
Looking at the uses of _state most are unordered atomics so I won't change them. But they might deserve a look |
vchuravy
reviewed
Aug 16, 2024
vchuravy
approved these changes
Aug 16, 2024
I presume this is good to go? |
giordano
removed
the
status:merge me
PR is reviewed. Merge when all tests are passing
label
Aug 20, 2024
KristofferC
pushed a commit
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.