Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use atomics for the StickyWorkqueue array instead of a lock #55514

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+1 −1
Open

Use atomics for the StickyWorkqueue array instead of a lock #55514

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e2b833
Use atomics for the StickyWorkqueue array instead of a lock
gbaraldi Aug 16, 2024
4f2105b
Apply suggestions from code review
gbaraldi Aug 16, 2024
e6ac5fe
Revert changes except the switch to a Memory
gbaraldi Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/task.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,7 @@ function list_deletefirst!(W::IntrusiveLinkedListSynchronized{T}, t::T) where T
end

const StickyWorkqueue = IntrusiveLinkedListSynchronized{Task}
global Workqueues::Vector{StickyWorkqueue} = [StickyWorkqueue()]
global Workqueues::Memory{StickyWorkqueue} = Memory{StickyWorkqueue}([StickyWorkqueue()])
const Workqueues_lock = Threads.SpinLock()
const Workqueue = Workqueues[1] # default work queue is thread 1 // TODO: deprecate this variable

Expand Down