Fix external IO loop thead interaction and add function to Base.Experimental to facilitate it's use. Also add a test. #55529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imental to facilitate it's use. Also add a test.
vtjnash
reviewed
Aug 19, 2024
vtjnash
reviewed
Aug 31, 2024
vtjnash
reviewed
Sep 16, 2024
vtjnash
reviewed
Oct 15, 2024
test/threads.jl
Outdated
|
|
||
| """ | ||
| proc = run(pipeline(`$(Base.julia_cmd()) -e $cmd`), wait=false) | ||
| sleep(10) # Is there a better way to do this? |
There was a problem hiding this comment.
Per previous discussion, this test needs to be rewritten to remove the sleep call before merging. The most common alternative is to set up a watchdog call such as t = Timer(60) do t; kill(proc); end; success(proc); close(t)
|
Bump! |
|
Is there a reason we don't want a separate IO thread to be the default? It seems like a better design. |
JeffBezanson
reviewed
Nov 6, 2024
| @@ -423,6 +445,8 @@ JL_DLLEXPORT jl_gcframe_t **jl_adopt_thread(void) | |||
| JL_GC_PROMISE_ROOTED(ct); | |||
| uv_random(NULL, NULL, &ct->rngState, sizeof(ct->rngState), 0, NULL); | |||
| jl_atomic_fetch_add(&jl_gc_disable_counter, -1); | |||
| ct->world_age = jl_get_world_counter(); // root_task sets world_age to 1 | |||
| jl_init_task_lock(ct); | |||
There was a problem hiding this comment.
Is this really needed for all adopted threads? Could we lazy initialize it when somebody tries to wait for the task instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at #55525 I found that the implementation wasn't working correctly.
I added it to Base.Experimental so people don't need to handroll their own and am also testing a version of what the issue was hitting.
@vtjnash Is the wakeup of thread 0 for libuv only or do I need to wake both the IO thread and thread 0 always?