-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain walkdir
docstring second example.
#55541
Conversation
|
Co-authored-by: Lilith Orion Hafner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Does this make sense & seem ready to merge to you, too?
Yep! It gives the user an expectation for the behavior and a link to dig deeper if desired. Thanks! |
As a funny aside, I spent the last two PRs thinking "LGTM" meant "Let's get to merge" and didn't bother looking it up until just now, but that did result in a pretty fast turnaround for these PRs 😆 |
To me, "LGTM"/"looks good to me" means "I would merge this as is". I'm also a fan of merging PRs reasonably quickly because PRs that sit open for long periods of time become stale, both technically and in the minds of authors and reviewers, which makes them harder to progress on. |
This is a follow-up documentation PR to #55476. I believe the second example in the `walkdir` docstring is still unintuitive since the result changes each time. I attempted a simple explanation, but I don't really know what I'm talking about. Hopefully someone else can explain what is happening better. Some additional discussion in [this Discourse post](https://discourse.julialang.org/t/find-all-files-named-findthis-csv-in-nested-subfolders-of-rootfolder/118096). --------- Co-authored-by: Lilith Orion Hafner <[email protected]>
This is a follow-up documentation PR to #55476. I believe the second example in the
walkdir
docstring is still unintuitive since the result changes each time. I attempted a simple explanation, but I don't really know what I'm talking about. Hopefully someone else can explain what is happening better. Some additional discussion in this Discourse post.