-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenBLAS_jll] Upgrade to v0.3.29 #57025
Conversation
OPENBLAS_SHA1=5ef8b1964658f9cb6a6324a06f6a1a022609b0c5 | ||
OPENBLAS_VER := 0.3.29 | ||
OPENBLAS_BRANCH=v0.3.29 | ||
OPENBLAS_SHA1=8795fc7985635de1ecf674b87e2008a15097ffab | ||
|
||
# LAPACK, source-only | ||
LAPACK_VER := 3.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ViralBShah I have no idea how to check what should be the lapack version here. Is it just whatever is the latest in https://www.netlib.org/lapack/ or we need to pick something specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should match what the openblas build is using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does one find that information?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the safest one: https://github.com/OpenMathLib/OpenBLAS/blob/4e817f804c61a3c7c94c3ce52db433ec20e83ab3/lapack-netlib/DOCS/Doxyfile#L41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need LAPACK build recipe in here. We always build it only as part of openblas. This seems to be for building LAPACK independently, and we do that in BB. I think we should be able to delete it altogether.
OpenBLAS v0.3.29 was released just 6 hours ago.
Note that OpenBLAS 0.3.29 doesn't support building for PowerPC with GCC before v11, which means we can't support libgfortran3 and 4 anymore. I feel like the same will happen in the near future for other architectures.