Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cases in broadcasting columns #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Feb 15, 2023

Using arrays

julia> B = brand(5000,5000,0,0); v = rand(size(B,1)); B2 = brand(5000,5000,2,2);

we obtain

Operation Master PR
B .* v 32.329 μs 28.289 μs
v .* B 38.244 μs 30.009 μs
B2 .* v 61.873 μs 59.356 μs
v .* B2 83.148 μs 72.213 μs

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 82.08% // Head: 81.84% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (5752977) compared to base (bcedda1).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   82.08%   81.84%   -0.24%     
==========================================
  Files          24       24              
  Lines        3321     3333      +12     
==========================================
+ Hits         2726     2728       +2     
- Misses        595      605      +10     
Impacted Files Coverage Δ
src/generic/broadcast.jl 93.93% <50.00%> (-1.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub
Copy link
Member Author

jishnub commented Feb 15, 2023

I can't really think of tests for the non-standard branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant