Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show for BandedMatrix may print the constructor #404

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Oct 6, 2023

After this PR

julia> B = BandedMatrix(-1=>1:4, 0=>1:5, 1=>1:4);

julia> show(B)
BandedMatrix(-1 => [1, 2, 3, 4], 0 => [1, 2, 3, 4, 5], 1 => [1, 2, 3, 4])

vs on master

julia> show(B)
[1 1 0 0 0; 1 2 2 0 0; 0 2 3 3 0; 0 0 3 4 4; 0 0 0 4 5]

The new display format is more informative, sparse and a valid constructor as well.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4f24c9d) 89.51% compared to head (ab18601) 89.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
+ Coverage   89.51%   89.54%   +0.02%     
==========================================
  Files          25       25              
  Lines        3529     3538       +9     
==========================================
+ Hits         3159     3168       +9     
  Misses        370      370              
Files Coverage Δ
src/banded/BandedMatrix.jl 95.20% <100.00%> (+0.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 0b24d5a into JuliaLinearAlgebra:master Oct 9, 2023
16 checks passed
@jishnub jishnub deleted the showBandedMatrix branch October 9, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant