Skip to content

Commit

Permalink
Fix col/rowsupport with range (#6)
Browse files Browse the repository at this point in the history
  • Loading branch information
dlfivefifty authored Jul 14, 2020
1 parent e849ca5 commit 668ee09
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
5 changes: 2 additions & 3 deletions Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "SemiseparableMatrices"
uuid = "f8ebbe35-cbfb-4060-bf7f-b10e4670cf57"
authors = ["Sheehan Olver <[email protected]>"]
version = "0.1"
version = "0.1.1"

[deps]
ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
Expand All @@ -18,10 +18,9 @@ BandedMatrices = "0.15.6"
BlockBandedMatrices = "0.8.3"
LazyArrays = "0.16.7"
LazyBandedMatrices = "0.2.7"
MatrixFactorizations = "0.4"
MatrixFactorizations = "0.4, 0.5"
julia = "1.3"


[extras]
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Expand Down
4 changes: 2 additions & 2 deletions src/AlmostBandedMatrix.jl
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,12 @@ Base.IndexStyle(::Type{ABM}) where {ABM<:AlmostBandedMatrix} =

function colsupport(::AbstractAlmostBandedLayout, A, j)
l,_ = almostbandwidths(A)
Base.OneTo(min(j+l,size(A,1)))
Base.OneTo(min(maximum(j)+l,size(A,1)))
end

function rowsupport(::AbstractAlmostBandedLayout, A, k)
l,_ = almostbandwidths(A)
max(1,k-l):size(A,2)
max(1,minimum(k)-l):size(A,2)
end

function getindex(B::AlmostBandedMatrix, k::Integer, j::Integer)
Expand Down

2 comments on commit 668ee09

@dlfivefifty
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/17934

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.1 -m "<description of version>" 668ee09079059de9ad28a78fda14630cb163ca6a
git push origin v0.1.1

Please sign in to comment.