Skip to content

Commit

Permalink
disambiguate Float16 eigen (#138)
Browse files Browse the repository at this point in the history
  • Loading branch information
jishnub authored Aug 10, 2024
1 parent 93d16cb commit 3d3cf05
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/eigen.jl
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
# The methods aren't defined for general Tridiagonal or Hermitian, as the
# ordering of eigenvectors needs fixing
for MT in (:(SymTridiagonal{<:Union{Real,Complex}, <:AbstractFillVector}),
:(Symmetric{T, <:Tridiagonal{T, <:AbstractFillVector{T}}} where {T<:Union{Real,Complex}})
:(Symmetric{T, <:Tridiagonal{T, <:AbstractFillVector{T}}} where {T<:Union{Real,Complex}}),
:(Symmetric{Float16, <:Tridiagonal{Float16, <:AbstractFillVector{Float16}}}),
)
@eval function eigvals(A::$MT)
n = size(A,1)
Expand All @@ -23,6 +24,7 @@ end

for MT in (:(SymTridiagonal{<:Union{Real,Complex}, <:AbstractFillVector}),
:(Symmetric{T, <:Tridiagonal{T, <:AbstractFillVector{T}}} where {T<:Union{Real,Complex}}),
:(Symmetric{Float16, <:Tridiagonal{Float16, <:AbstractFillVector{Float16}}}),
)

@eval begin
Expand Down

2 comments on commit 3d3cf05

@jishnub
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/112823

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.8.4 -m "<description of version>" 3d3cf0534cb4a2c619e6f2a8620eb47c895554a0
git push origin v0.8.4

Please sign in to comment.