Preserve types in triangular constructors #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
This is not ideal, as the
UpperTriangular
constructor should create an object of that type. This PR changes this toThis wrapper would allow one to use optimized
LinearAlgebra
functions that are defined forUpperTriangular
/LowerTriangular
, although there is a certain degree of redundancy present.Similarly, change
Symmetric(::AbstractToeplitz)
to return a wrapper instead of aSymmetricToeplitz
.Since this was explicitly implemented this way and was being tested for, I have marked this change as breaking (minor version update). This also allows us to bump the Julia compatibility and drop support for v1.0. This should close #91.