Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit factorization size method to Circulant #130

Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jan 25, 2024

With this method, a Circulant satisfies

julia> C = Circulant(1:4);

julia> size(C) == size(factorize(C))
true

This doesn't hold for other AbstractToeplitz types given the current definition, so it's best to limit these for now.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (135d562) 95.63% compared to head (fd24ac4) 95.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   95.63%   95.63%           
=======================================
  Files           9        9           
  Lines         963      963           
=======================================
  Hits          921      921           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 131933a into JuliaLinearAlgebra:master Jan 25, 2024
13 checks passed
@jishnub jishnub deleted the sizeCirculantFactorization branch January 25, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant