Apply suggestions from code review

Co-authored-by: Mateusz Baran <[email protected]>
JuliaManifolds · Dec 24, 2023 · 4c05d8e · 4c05d8e
1 parent f8080e2
commit 4c05d8e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -11,7 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 * introduced a nonzero `atol` for all point and vector checks that compre to zero.
   This makes those checks a bit more relaxed by default and resolves [#630](https://github.com/JuliaManifolds/Manifolds.jl/issues/630).
-* `get_estimation_method(M)` is deprecated, use `get_approximation_method(M, f)` for your specific mathod `f` on the manifold `M`.
+* `default_estimation_method(M, f)` is deprecated, use `default_approximation_method(M, f)` for your specific method `f` on the manifold `M`.
+* `AbstractEstimationMethod` is deprecated, use `AbstractApproximationMethod` instead.
 
 ## [0.9.8] - 2023-11-17
 

diff --git a/src/statistics.jl b/src/statistics.jl
@@ -407,7 +407,7 @@ function Statistics.mean!(
     x::AbstractVector,
     w::AbstractVector,
     e::ExtrinsicEstimation;
-    extrinsic_method=nothing,
+    extrinsic_method::Union{AbstractEstimationMethod,Nothing}=nothing,
     kwargs...,
 )
     if !isnothing(extrinsic_method)